0001489: Render button should not be a drop down menu

View Issue Details [ Jump to Notes ]

[ Issue History ] [ Print ]

Project

Category

View Status

Date Submitted

Last Update

0001489

Kdenlive

User Interface

public

2010-03-07 22:23

2010-09-22 17:54

Reporter

LeHomard

Assigned To

xzhayon

Priority

low

Severity

tweak

Reproducibility

always

Status

closed

Resolution

fixed

Platform

64 bit

Kubuntu Linux

OS Version

9.10

Product Version

Recent git

Target Version

0.7.8

Fixed in Version

0.7.8

Summary

0001489: Render button should not be a drop down menu

Description

At the moment the render button is actually a clickable dropdown list, which is unorthodox and fairly confusing from a user stand point. It simply isn't obvious that it is clickable. It also makes it easy to click the button instead of the arrow on left.

There are also only two options : Render and Generate Script. It is therefore easy to simply have two separate buttons side by side.

I have provided a patch that makes that little change (two buttons instead of dropdown list). It is not much, but this has been bugging me for a while ;)

Feel free to test it and commit it to svn.

Additional Information

Index: src/widgets/renderwidget_ui.ui
===================================================================
--- src/widgets/renderwidget_ui.ui (revision 4347)
+++ src/widgets/renderwidget_ui.ui (working copy)
@@ -277,13 +277,20 @@
          </layout>
         </widget>
        </item>
- <item row="13" column="0" colspan="3">
- <widget class="QToolButton" name="buttonStart">
- <property name="popupMode">
- <enum>QToolButton::MenuButtonPopup</enum>
+ <item row="13" column="0" colspan="2">
+ <widget class="QPushButton" name="buttonRender">
+ <property name="text">
+ <string>Render</string>
          </property>
         </widget>
        </item>
+ <item row="13" column="2" colspan="1">
+ <widget class="QPushButton" name="buttonGenerateScript">
+ <property name="text">
+ <string>Generate Script</string>
+ </property>
+ </widget>
+ </item>
        <item row="13" column="3" colspan="6">
         <spacer name="horizontalSpacer">
          <property name="orientation">
Index: src/renderwidget.cpp
===================================================================
--- src/renderwidget.cpp (revision 4347)
+++ src/renderwidget.cpp (working copy)
@@ -92,16 +92,9 @@
     m_view.rescale_size->setText("320x240");

- QMenu *renderMenu = new QMenu(i18n("Start Rendering"), this);
- QAction *renderAction = renderMenu->addAction(KIcon("video-x-generic"), i18n("Render to File"));
- connect(renderAction, SIGNAL(triggered()), this, SLOT(slotPrepareExport()));
- QAction *scriptAction = renderMenu->addAction(KIcon("application-x-shellscript"), i18n("Generate Script"));
- connect(scriptAction, SIGNAL(triggered()), this, SLOT(slotGenerateScript()));
+ connect(m_view.buttonRender, SIGNAL(clicked()), this, SLOT(slotPrepareExport()));
+ connect(m_view.buttonGenerateScript, SIGNAL(clicked()), this, SLOT(slotGenerateScript()));

- m_view.buttonStart->setMenu(renderMenu);
- m_view.buttonStart->setPopupMode(QToolButton::MenuButtonPopup);
- m_view.buttonStart->setDefaultAction(renderAction);
- m_view.buttonStart->setToolButtonStyle(Qt::ToolButtonTextOnly);
     m_view.abort_job->setEnabled(false);
     m_view.start_script->setEnabled(false);
     m_view.delete_script->setEnabled(false);
@@ -151,7 +144,8 @@

     connect(m_view.format_selection, SIGNAL(activated(int)), this, SLOT(refreshView()));

- m_view.buttonStart->setEnabled(false);
+ m_view.buttonRender->setEnabled(false);
+ m_view.buttonGenerateScript->setEnabled(false);
     m_view.rescale_size->setEnabled(false);
     m_view.guides_box->setVisible(false);
     m_view.open_dvd->setVisible(false);
@@ -293,15 +287,18 @@
  */
void RenderWidget::slotUpdateButtons(KUrl url)
{
- if (m_view.out_file->url().isEmpty()) m_view.buttonStart->setEnabled(false);
+ if (m_view.out_file->url().isEmpty()) {
+ m_view.buttonGenerateScript->setEnabled(false);
+ m_view.buttonRender->setEnabled(false);
+ }
     else {
         updateButtons(); // This also checks whether the selected format is available
- //m_view.buttonStart->setEnabled(true);
     }
     if (url != 0) {
         QListWidgetItem *item = m_view.size_list->currentItem();
         if (!item) {
- m_view.buttonStart->setEnabled(false);
+ m_view.buttonRender->setEnabled(false);
+ m_view.buttonGenerateScript->setEnabled(false);
             return;
         }
         QString extension = item->data(ExtensionRole).toString();
@@ -316,9 +313,11 @@
  */
void RenderWidget::slotUpdateButtons()
{
- if (m_view.out_file->url().isEmpty()) m_view.buttonStart->setEnabled(false);
+ if (m_view.out_file->url().isEmpty()) {
+ m_view.buttonRender->setEnabled(false);
+ m_view.buttonGenerateScript->setEnabled(false);
+ }
     else updateButtons(); // This also checks whether the selected format is available
- //else m_view.buttonStart->setEnabled(true);
}

void RenderWidget::slotSaveProfile()
@@ -619,10 +618,12 @@
         m_view.buttonSave->setEnabled(false);
         m_view.buttonDelete->setEnabled(false);
         m_view.buttonEdit->setEnabled(false);
- m_view.buttonStart->setEnabled(false);
+ m_view.buttonRender->setEnabled(false);
+ m_view.buttonGenerateScript->setEnabled(false);
     } else {
         m_view.buttonSave->setEnabled(true);
- m_view.buttonStart->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
+ m_view.buttonRender->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
+ m_view.buttonGenerateScript->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
         QString edit = m_view.size_list->currentItem()->data(EditableRole).toString();
         if (edit.isEmpty() || !edit.endsWith("customprofiles.xml")) {
             m_view.buttonDelete->setEnabled(false);
@@ -1102,7 +1103,8 @@
     QListWidgetItem *item = m_view.size_list->currentItem();
     if (!item || item->isHidden()) {
         m_view.advanced_params->clear();
- m_view.buttonStart->setEnabled(false);
+ m_view.buttonRender->setEnabled(false);
+ m_view.buttonGenerateScript->setEnabled(false);
         return;
     }
     QString params = item->data(ParamsRole).toString();
@@ -1138,7 +1140,8 @@
         m_view.buttonEdit->setEnabled(true);
     }

- m_view.buttonStart->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
+ m_view.buttonRender->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
+ m_view.buttonGenerateScript->setEnabled(m_view.size_list->currentItem()->toolTip().isEmpty());
}

void RenderWidget::reloadProfiles()

Notes
(0004888) xzhayon (developer) 2010-03-30 14:15	could you please attach the patch instead of pasting it? that would make its testing way easier ;)

(0004890) LeHomard (developer) 2010-03-30 15:43	I think at the time I couldn't find the file upload button (maybe I can now I'm a developer...), so I just pasted the patch here and sent the patch file on the develepers mailing list. I can upload the patch here as well if you want.

(0004893) xzhayon (developer) 2010-03-30 16:56	not necessary, thanks fix committed in revision 4364

Issue History
Date Modified	Username	Field	Change
2010-03-07 22:23	LeHomard	New Issue
2010-03-30 14:15	xzhayon	Note Added: 0004888
2010-03-30 14:15	xzhayon	Status	new => feedback
2010-03-30 14:16	xzhayon	Status	feedback => assigned
2010-03-30 14:16	xzhayon	Assigned To	=> xzhayon
2010-03-30 14:16	xzhayon	Status	assigned => feedback
2010-03-30 15:43	LeHomard	Note Added: 0004890
2010-03-30 15:43	LeHomard	Status	feedback => assigned
2010-03-30 16:56	xzhayon	Note Added: 0004893
2010-03-30 16:56	xzhayon	Status	assigned => resolved
2010-03-30 16:56	xzhayon	Fixed in Version	=> Recent git
2010-03-30 16:56	xzhayon	Resolution	open => fixed
2010-03-30 17:07	xzhayon	Target Version	=> future version
2010-09-14 11:01	j-b-m	Fixed in Version	Recent git => 0.7.8
2010-09-14 23:00	j-b-m	Status	resolved => closed
2010-09-22 17:54	Granjow	Target Version	future version => 0.7.8

Relationships