| View Issue Details [ Jump to Notes ] | [ Issue History ] [ Print ] |
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0002077 | Kdenlive | Build System | public | 2011-03-26 22:27 | 2011-06-10 10:49 |
|
| Reporter | fleury | |
| Assigned To | j-b-m | |
| Priority | normal | Severity | minor | Reproducibility | always |
| Status | closed | Resolution | fixed | |
| Platform | 32 bits i686 | OS | Linux Kubuntu 10.10 | OS Version | 2.6.35 |
| Product Version | Recent git | |
| Target Version | | Fixed in Version | 0.8 | |
|
| Summary | 0002077: Fix for all existing warnings while compiling |
| Description | The attached patch fixes most warnings that I see when compiling from SVN.
They are mainly signed/unsigned comparisons, a missing virtual destructor and some unused or uninitialized variables. 2 problems stand out though:
- the write frame in blackmagic code may actually loose data if the system interrupts the write call. I have written a function that does not loose this data, but I have no such device so I can't test the code.
- many definitions of unions in the videodev2.h file actually define a _type_ and not a data structure (it would need a name to the union to do so). This also means that said unions are probably not used anywhere, but adding names to them may change the memory size of these so I did not touch them.
I think that it would be worth fixing those as well before the release. I am happy to do it as another patch, bu commenting the unions out probably. |
| Tags | No tags attached. |
|
| Build/Install Method | Manual build from SVN |
|
| Attached Files |  fix_warnings.patch.gz [^] (1,799 bytes) 2011-03-26 22:27 |
|
Kdenlive bug tracker
Home page
Relationships 
Relationships 