0002807: DVD wizard loop option for menu is broken

(0008564)
j-b-m (administrator)
2012-10-30 16:22

Kdenlive's DVD wizard is not really reliable. I have rewritten parts of it for the next release (image and color background are now working) but having a movie as menu background is currently not working. I will try to fix it for next release.

(0008565)
ptitmain (developer)
2012-10-30 16:32

I would be happy to test it !
:)

(0008660)
dtmonterrey (reporter)
2012-11-24 15:29

Hi

I just registered to say I would like to test any new code to solve this bug :)

(0008683)
dtmonterrey (reporter)
2012-12-02 00:41

Hi kdenlive gurus

In pursuing this bug, I'm hacking a C++ project for the first time: kdenlive :)

Before attempting whats happening I found that loading a dvdproject with a video as a menu background left the KComboBox selected as video but with the color select button visible instead of the KUrlRequester with the video for the menu background.

I found a solution and next is my patch

diff --git a/src/dvdwizardmenu.cpp b/src/dvdwizardmenu.cpp
index b922bf9..9ee1e4f 100644
--- a/src/dvdwizardmenu.cpp
+++ b/src/dvdwizardmenu.cpp
@@ -818,12 +818,15 @@ void DvdWizardMenu::loadXml(QDomElement xml)
     m_view.create_menu->setChecked(xml.attribute("enabled").toInt());
     if (xml.hasAttribute("background_color")) {
         m_view.background_list->setCurrentIndex(0);
+ checkBackgroundType(m_view.background_list->currentIndex());
         m_view.background_color->setColor(xml.attribute("background_color"));
     } else if (xml.hasAttribute("background_image")) {
         m_view.background_list->setCurrentIndex(1);
+ checkBackgroundType(m_view.background_list->currentIndex());
         m_view.background_image->setUrl(KUrl(xml.attribute("background_image")));
     } else if (xml.hasAttribute("background_video")) {
         m_view.background_list->setCurrentIndex(2);
+ checkBackgroundType(m_view.background_list->currentIndex());
         m_view.background_image->setUrl(KUrl(xml.attribute("background_video")));
     }

Can someone verify this and apply if ok?

Thanks

back to hacking :)

(0008684)
dtmonterrey (reporter)
2012-12-02 01:52

Hi everyone, again :)

I found a solution (I think I'm on the right bug)

On src/dvdwizard.cpp:310 we are assuming a default timeout of 30 seconds and that's not enough for the movie menu background to finish. In my test case I just increased it to 300 seconds and I have the DVD.iso done :)

I think we should put a timeout of +/- 10 minutes or remove the timeout completely.

Hope this is helpful...

By the way: kdenlive rocks!!!

(0008704)
j-b-m (administrator)
2012-12-08 17:54

@dtmonterrey:

Thanks for looking at the code. I fixed both issues you mentionned (in a slightly different way for the first issue). Should work now with latest git.

regards

(0008837)
ptitmain (developer)
2012-12-19 21:50

Works fine !!!

Issue History
Date Modified	Username	Field	Change
2012-10-30 13:50	ptitmain	New Issue
2012-10-30 16:22	j-b-m	Note Added: 0008564
2012-10-30 16:22	j-b-m	Assigned To	=> j-b-m
2012-10-30 16:22	j-b-m	Status	new => acknowledged
2012-10-30 16:32	ptitmain	Note Added: 0008565
2012-11-24 15:29	dtmonterrey	Note Added: 0008660
2012-12-02 00:41	dtmonterrey	Note Added: 0008683
2012-12-02 01:52	dtmonterrey	Note Added: 0008684
2012-12-08 17:54	j-b-m	Note Added: 0008704
2012-12-08 17:54	j-b-m	Status	acknowledged => feedback
2012-12-19 21:50	ptitmain	Note Added: 0008837
2012-12-19 21:50	ptitmain	Status	feedback => assigned
2012-12-19 21:50	ptitmain	Status	assigned => resolved
2012-12-19 21:50	ptitmain	Fixed in Version	=> 0.9.4
2012-12-19 21:50	ptitmain	Resolution	open => fixed
2013-01-28 19:51	j-b-m	Status	resolved => closed

Notes
(0008564) j-b-m (administrator) 2012-10-30 16:22	Kdenlive's DVD wizard is not really reliable. I have rewritten parts of it for the next release (image and color background are now working) but having a movie as menu background is currently not working. I will try to fix it for next release.

(0008565) ptitmain (developer) 2012-10-30 16:32	I would be happy to test it ! :)

(0008660) dtmonterrey (reporter) 2012-11-24 15:29	Hi I just registered to say I would like to test any new code to solve this bug :)

(0008683) dtmonterrey (reporter) 2012-12-02 00:41	Hi kdenlive gurus In pursuing this bug, I'm hacking a C++ project for the first time: kdenlive :) Before attempting whats happening I found that loading a dvdproject with a video as a menu background left the KComboBox selected as video but with the color select button visible instead of the KUrlRequester with the video for the menu background. I found a solution and next is my patch diff --git a/src/dvdwizardmenu.cpp b/src/dvdwizardmenu.cpp index b922bf9..9ee1e4f 100644 --- a/src/dvdwizardmenu.cpp +++ b/src/dvdwizardmenu.cpp @@ -818,12 +818,15 @@ void DvdWizardMenu::loadXml(QDomElement xml) m_view.create_menu->setChecked(xml.attribute("enabled").toInt()); if (xml.hasAttribute("background_color")) { m_view.background_list->setCurrentIndex(0); + checkBackgroundType(m_view.background_list->currentIndex()); m_view.background_color->setColor(xml.attribute("background_color")); } else if (xml.hasAttribute("background_image")) { m_view.background_list->setCurrentIndex(1); + checkBackgroundType(m_view.background_list->currentIndex()); m_view.background_image->setUrl(KUrl(xml.attribute("background_image"))); } else if (xml.hasAttribute("background_video")) { m_view.background_list->setCurrentIndex(2); + checkBackgroundType(m_view.background_list->currentIndex()); m_view.background_image->setUrl(KUrl(xml.attribute("background_video"))); } Can someone verify this and apply if ok? Thanks back to hacking :)

(0008684) dtmonterrey (reporter) 2012-12-02 01:52	Hi everyone, again :) I found a solution (I think I'm on the right bug) On src/dvdwizard.cpp:310 we are assuming a default timeout of 30 seconds and that's not enough for the movie menu background to finish. In my test case I just increased it to 300 seconds and I have the DVD.iso done :) I think we should put a timeout of +/- 10 minutes or remove the timeout completely. Hope this is helpful... By the way: kdenlive rocks!!!

(0008704) j-b-m (administrator) 2012-12-08 17:54	@dtmonterrey: Thanks for looking at the code. I fixed both issues you mentionned (in a slightly different way for the first issue). Should work now with latest git. regards

(0008837) ptitmain (developer) 2012-12-19 21:50	Works fine !!!

Relationships